Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve port binding and db error msgs #509

Merged
merged 17 commits into from
May 25, 2018
Merged

Improve port binding and db error msgs #509

merged 17 commits into from
May 25, 2018

Conversation

aionick
Copy link
Contributor

@aionick aionick commented May 25, 2018

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • Improve the p2p error message when unable to bind to a port. Also improved the db error messages for the case when two instances try using the same db and it locks out the second one.

This PR is dependent on the changes in Pr #507, the only commit that belongs to this PR is: 5f4ecec.

Fixes Issue #69.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • Used manual testing, running two kernels on the same port and then running two kernels on the same db instance for each db we support.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT merged commit 4466731 into aionnetwork:p2p-outbound May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants