Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly shutdown zmq socket #505

Merged
merged 1 commit into from
Jun 13, 2018
Merged

properly shutdown zmq socket #505

merged 1 commit into from
Jun 13, 2018

Conversation

AionJayT
Copy link
Collaborator

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • Zmq socket doesn't shutdown properly. It causes the client side native zmq lib has a chance to throw errors and crash the application when the kernel is shutting down.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • use javaAPI client API test suite to verify the issues.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the bug Something isn't working label May 24, 2018
@AionJayT AionJayT added this to the v0.2.8 - University Peak milestone May 24, 2018
Copy link
Contributor

@ali-sharif ali-sharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can verify that graceful kernel shutdowns won't cause client to ungracefully shutdown. On the client-side, still the issue that if the kernel is not shutdown gracefully, cleint causes consuming application to crash (see aionnetwork/aion_api#26)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants