Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align class names with current functionality #1152

Merged
merged 3 commits into from
May 8, 2020
Merged

Align class names with current functionality #1152

merged 3 commits into from
May 8, 2020

Conversation

AlexandraRoatis
Copy link
Contributor

Type of change

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Apr 24, 2020
@AlexandraRoatis AlexandraRoatis added this to the 1.6 milestone Apr 24, 2020
@AlexandraRoatis AlexandraRoatis self-assigned this Apr 24, 2020
AlexandraRoatis and others added 3 commits May 8, 2020 10:52
@AlexandraRoatis @AionJayT
Rename A0BlockHeader to MiningBlockHeader
cab192c
@AlexandraRoatis @AionJayT
Rename AionBlock to MiningBlock
816b3d8
@AionJayT
Rename BlockSealType to Seal
a442b06 
    Since the enum is part of the BlockHeader interface, it does not need
    a long name to relate to block.

    Also renamed the enum items as follows:
    - SEAL_NA to NOT_APPLICABLE
    - SEAL_POW_BLOCK to PROOF_OF_WORK
    - SEAL_POS_BLOCK to PROOF_OF_STAKE
    This remaning is meant to reduce visual confusion when dealing with
    the POS and POW seal types.
@AionJayT AionJayT merged commit a442b06 into master May 8, 2020
@AionJayT AionJayT deleted the block-rename branch May 8, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AionJayT AionJayT Awaiting requested review from AionJayT

Assignees

@AlexandraRoatis AlexandraRoatis

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandraRoatis @AionJayT