Pruning Tests and Bug Fixes #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraRoatis
added
bug
AlexandraRoatis
force-pushed
the
AKI-667
branch
from
47d415a to
f22f114
Compare
AlexandraRoatis
force-pushed
the
AKI-667
branch
2 times, most recently
from
791d086 to
1ac3547
Compare
AionJayT
reviewed
Mar 18, 2020
| @@ -512,10 +512,6 @@ public void flush() { | |||
| db.commit(); | |||
| } | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
What scenario we will see the databaseGroup equal to null ? Sometimes We can see this message during the seednode running, also the project test case.
There was a problem hiding this comment.
The databaseGroup is null when using a repository snapshot. The snapshot is always used when importing a side chain block. The message is really useless, cause it doesn't notify us of anything meaningful.
AionJayT
reviewed
Mar 18, 2020
AionJayT
reviewed
Mar 18, 2020
| return null; | ||
| } else { | ||
| StakingBlock blockTemplate; | ||
| blockTemplateLock.lock(); | ||
| try { | ||
| blockTemplate = blockchain.createStakingBlockTemplate( | ||
| mempool.getPendingTransactions(), signingPublicKey, newSeed, coinbase); | ||
| blockTemplate = blockchain.createStakingBlockTemplate(best, mempool.getPendingTransactions(), signingPublicKey, newSeed, coinbase); |
There was a problem hiding this comment.
Should we just use blockTemplateLock and the try...finally to include all of the method?
Same as the getMiningBlockTemplate
There was a problem hiding this comment.
I added an extra commit for this change.
These are accounts for producing transactions that are not involved in staking.
JournalPruneDataSource already rolls back the side chain blocks.
The staking blocks were always created on top of the best block. This is a valid setup for the staker tools but it prevents testing the functionality with side chains. Additionally, this is a bug fix for AionHub. The hub could cause incorrect block creation due to the fact that it was calling the getBestBlock method in the blockchain twice without synchronization. This bug fix may relate to AKI-657.
The test is ignored for now pending the fix for AKI-677.
AlexandraRoatis
force-pushed
the
AKI-667
branch
from
388ae1e to
ee8c73b
Compare
AionJayT
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change