AKI-672: Call repository close on main instance #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AionJayT
reviewed
Mar 6, 2020
| @@ -2186,6 +2187,14 @@ public synchronized void setBestBlock(Block block) { | |||
|
|
|||
| @Override | |||
| public synchronized void close() { | |||
| while (repository.isSnapshot()) { | |||
| popState(); | |||
There was a problem hiding this comment.
Does the kernel flush the DB before the shutdown process? If the answer is no, why we do popState?
There was a problem hiding this comment.
The main repository instance is stashed when the snapshot is created. If the current repository is a snapshot that means the main one is in the stack. So we need to pop the stack until we get to the main repository instance that contains access too all the databases that must be closed.
If the close was called under normal circumstances the repository was already flushed. If it was called due to an error (like a VM issue) then flushing may store corrupt data, so it shouldn't be done.
When the close method is called due to a critical error the databases that are not copied into a snapshot may remain open. This is because during execution the main repository can be stashed while a snapshot is used for the block import.
AlexandraRoatis
force-pushed
the
AKI-672
branch
2 times, most recently
from
7eb7561 to
c1b66dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change