Blockstore use clean-up #1122
Merged
Blockstore use clean-up #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraRoatis
force-pushed
the
blockstore
branch
from
2351d63 to
797acb8
Compare
AionJayT
reviewed
Mar 4, 2020
| @@ -125,7 +120,7 @@ private void initializeHub( | |||
| blockchain.setEventManager(this.eventMgr); | |||
|
|
|||
| try { | |||
| loadBlockchain(); | |||
| startingBlock = this.blockchain.load(cfg.getGenesis(), genLOG); | |||
There was a problem hiding this comment.
the line 131 can be removed. duplicate assignation.
AlexandraRoatis
force-pushed
the
blockstore
branch
2 times, most recently
from
424ff32 to
c1487d7
Compare
This is a step towards limiting access to the block store. The long term goal is to allow only the repository to retrieve block data from the block store and pass it further.
As a result DBUtils no longer accesses the block store directly.
The messages now give a better indications of when an error occured.
Reduces access to the block store by forwarding calls to the blockchain and repository. Also removed the unnecessary hash wrapping.
Having all the functionality to load the blockchain inside the hub requires exposing data elements that would otherwise be kept private. Additionally, the method becomes easier to read when directly making use of the blockchain internal attributes.
The method is no longer used outside the test that checks its functionality. It was a hacky way of creating large chains for testing that can be replaced with the chain generation functionality from BlockchainTestUtils.
Access to the block store must go though the repository.
AlexandraRoatis
force-pushed
the
blockstore
branch
from
c1487d7 to
50ea22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change