Repository and contract details clean up #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cached encoding creates unnecessary overhead. It is used only when storing dirty accounts. An account will have reset the encoding when it has changes that enable the dirty flag. So there is no computation saved by caching the encoding.
The loadAccountState method was relying on each implementation to copy the account state and contract details into the provided caches. This functionality is easier to maintain when the two objects are returned instead of them being placed directly in the caches.
This is a first step towards removing the VM setters and getters from the ContractDetails interface.
This is the next step in removing the setter for the VM types from the ContractDetails interface. It has the addtional benefit of reducing the number of locks acquired for accessing data in AionRepositoryCache.
It reduces the number of locks that need to be aquired to read the account state information.
This is a step towards refining the contract details interfaces to contain only the necessary methods.
The stored implementation can use the final address instance variable. InnerContractDetails no longer needs the method.
The check is incorrectly comparing the code hash with the trie hash. It results in always updating the state root. The check cannot be corrected because the genesis contains a contract with empty code. Therefore the best option is to remove the check.
Reduces the number of byte array copies made during execution.
AlexandraRoatis
force-pushed
the
AKI-435-PR
branch
from
7eef9da to
d78d802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change