Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKI 317: TransactionStore enhancements #1017

Merged
merged 3 commits into from
Oct 21, 2019
Merged

AKI 317: TransactionStore enhancements #1017

merged 3 commits into from
Oct 21, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis commented Oct 17, 2019 •
edited
Loading

Description

  • Using the wrapped block hash inside AionTxInfo;
  • Changing the serialization to use sets instead of lists;
  • Switched transaction storage to an overwrite policy:
    • the ability to overwrite previously-stored transaction information is necessary to apply config updates to store internal transactions or not to store them;
    • removed caching optimization: not particularly useful;
    • removed unused return value for putTxInfoToBatch method.

Completes task AKI-317.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Oct 17, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.5.0 (Unity) milestone Oct 17, 2019
@AlexandraRoatis AlexandraRoatis self-assigned this Oct 17, 2019
@AlexandraRoatis AlexandraRoatis force-pushed the AKI-317 branch 2 times, most recently from ce6b6a6 to 2230019 Compare October 21, 2019 23:13
@AlexandraRoatis
Updated tx info serialization to read data into a map:
825c7a8 
 - the transaction information is added to the map using as key the block hash
 where the transaction was included in the chain;
 - the actual transaction info data storage remains unchanged;
 - retrieving the transaction information for a specific block is simplified
 by the ability to get it based on the block hash instead of looping through
 the full list of infos stored for all known chains.
@AlexandraRoatis
Switched transaction storage to an overwrite policy:
2230019 
 - the ability to overwrite previously stored transaction information is necessary to
 apply config updates to store internal transactions or not to store them;
 - removed caching optimization: not particularly useful;
 - removed unused return value for putTxInfoToBatch method.
@AlexandraRoatis AlexandraRoatis merged commit 2230019 into master Oct 21, 2019
@AlexandraRoatis AlexandraRoatis deleted the AKI-317 branch October 21, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AionJayT AionJayT Awaiting requested review from AionJayT

@aionick aionick Awaiting requested review from aionick

@geoff-aion geoff-aion Awaiting requested review from geoff-aion

Assignees

@AlexandraRoatis AlexandraRoatis

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0 Denali (Unity consensus)
Development

Successfully merging this pull request may close these issues.
1 participant
@AlexandraRoatis