Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static factory methods for creating blocks #1011

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Static factory methods for creating blocks #1011

merged 2 commits into from
Oct 9, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

Description

  • Static factory methods for creating blocks.
  • Bugfixes: BroadcastNewBlockHandler, ResponseBlocks and ResBlocksHeaders were incorrectly using enum ordinal instead of seal id.
  • Using EnumMap in chain config for increased performance and code maintenance.

Fixes Issue AKI-369.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

@AlexandraRoatis AlexandraRoatis added bug Something isn't working enhancement New feature or request labels Oct 8, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.5.0 (Unity) milestone Oct 8, 2019
@AlexandraRoatis AlexandraRoatis self-assigned this Oct 8, 2019
@AlexandraRoatis
AKI-369: Static factory methods for creating blocks;
c3328ad 
Bugfixes: BroadcastNewBlockHandler, ResponseBlocks and ResBlocksHeaders were incorrectly using enum ordinal instead of seal id.
@AlexandraRoatis
Using EnumMap in chain config for increased performance and code main…
c7d6615 
…tenance.
@AlexandraRoatis AlexandraRoatis merged commit c7d6615 into master Oct 9, 2019
@AlexandraRoatis AlexandraRoatis deleted the AKI-369 branch October 9, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

@AionJayT AionJayT Awaiting requested review from AionJayT

Assignees

@AlexandraRoatis AlexandraRoatis

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
1.0 Denali (Unity consensus)
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandraRoatis @arajasek