Meta Transactions #1001
Merged
Meta Transactions #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-aion
force-pushed
the
geoff-meta-tx-rebase
branch
6 times, most recently
from
8728698 to
03ffca2
Compare
AlexandraRoatis
suggested changes
Oct 2, 2019
There was a problem hiding this comment.
I think the RPC method for getting the tx info by hash should be extended to also retrieve the info when an alias is provided. The fact that the tx was an invokable one should not require changes in behavior for the user who is supposed to get introduced to normal blockchain interaction.
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java
Outdated
Show resolved
Hide resolved
geoff-aion
force-pushed
the
geoff-meta-tx-rebase
branch
2 times, most recently
from
d5c9642 to
9d56c7b
Compare
…tTransactionInfo can retreive them
geoff-aion
force-pushed
the
geoff-meta-tx-rebase
branch
from
9d56c7b to
ff66a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
Please submit your PR to the
masterbranch and rebase your code onmasterbefore opening the pull request.Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.
Fixes Issue # .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.