Sync refactoring to improve performance #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AionJayT
reviewed
Oct 2, 2019
| // delay sending the request if we have multiple peers and the last sent message was to | ||
| // the current peer by placing the request in the pendingRequests that will be processed | ||
| // during the next iteration | ||
| if (mgr.getActiveNodes().size() > 1 && node.getIdHash() == lastNode.getIdHash()) { |
There was a problem hiding this comment.
not a big concern, the size check can just use " ! isEmpty()"
There was a problem hiding this comment.
Actually, here the difference is between 1 or larger. If only 1 peer exists, we will not enforce the requirement of not sending another request to the same peer.
AlexandraRoatis
force-pushed
the
AKI-373
branch
3 times, most recently
from
c38ce32 to
77d9322
Compare
This reverts commit 52eaefe.
AlexandraRoatis
force-pushed
the
AKI-373
branch
from
77d9322 to
4c4794d
Compare
- algorithm to avoid sending consecutive requests to the same peer when having multiple peers; - merged TaskWrite into TaskSend.
- Removed the storage of status blocks since it was heavy and only marginally useful.
- unifies state tracking for making header requests; - managing received responses; - initial unit tests.
- simplified import block functionality; - removed sync-related constants from p2p module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrote the sync algorithm to use a header request manager that keeps track of peer states and received headers. Simplifies sync state management and improves performance.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):