Add with_suffix
#670
Merged
Add with_suffix
#670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 99.72% 99.73%
=======================================
Files 4 4
Lines 739 750 +11
Branches 168 170 +2
=======================================
+ Hits 737 748 +11
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
reviewed
Jan 23, 2022
asvetlov
reviewed
Jan 23, 2022
|
@asvetlov done |
asvetlov
approved these changes
Feb 14, 2022
|
Thanks! |
q0w
added a commit
to q0w/yarl
that referenced
this pull request
Mar 29, 2022
|
Hi! I got v1.7.2 and this merge is still missing from it, it seems? |
|
@michaelaye I think, it exists in v1.8 |
|
ah, but no conda package after 1.7.2 hence the confusion. Is there a problem with building conda? Need help? |
|
conda-forge/yarl-feedstock#45 is still open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds
suffix,suffixes,with_suffixAre there changes in behavior for the user?
Related issue number
Closes #613
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.