Stop reencoding URL when calling with_port()

CHANGES/623.bugfix.rst

@@ -0,0 +1 @@
+Changed call in `with_port()` to stop reencoding parts of the URL that were already encoded.

tests/test_url_update_netloc.py

@@ -202,6 +202,11 @@ def test_with_port_keeps_query_and_fragment():
     assert str(url.with_port(8888)) == "http://example.com:8888/?a=1#frag"
 
 
+def test_with_port_percent_encoded():
+    url = URL("http://user%name:pass%[email protected]/")
+    assert str(url.with_port(808)) == "http://user%25name:pass%[email protected]:808/"
+
+
 def test_with_port_for_relative_url():
     with pytest.raises(ValueError):
         URL("path/to").with_port(1234)

yarl/_url.py

@@ -883,9 +883,7 @@ def with_port(self, port):
         val = self._val
         return URL(
             self._val._replace(
-                netloc=self._make_netloc(
-                    val.username, val.password, val.hostname, port, encode=True
-                )
+                netloc=self._make_netloc(val.username, val.password, val.hostname, port)
             ),
             encoded=True,
         )