Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errors in unquoter #521

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Conversation

serhiy-storchaka
Copy link
Contributor

  • No longer raise ValueError for % followed by non-hexdigits.
  • Fix decoding % followed by a space and hexdigit.

Closes #516.
Closes #520.

* No longer raise ValueError for % followed by non-hexdigits.
* Fix decoding % followed by a space and hexdigit.
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #521 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           4        4           
  Lines         739      739           
  Branches      168      167    -1     
=======================================
  Hits          737      737           
  Misses          2        2           
Impacted Files Coverage Δ
yarl/_quoting_py.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12b4d0...7d81968. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 28, 2020

This pull request fixes 1 alert when merging 8c432d3 into 5967c55 - view on LGTM.com

fixed alerts:

  • 1 for Nested loops with same variable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 30, 2020

This pull request fixes 1 alert when merging 7d81968 into 7add4d4 - view on LGTM.com

fixed alerts:

  • 1 for Nested loops with same variable

@asvetlov asvetlov merged commit d1d9c8c into aio-libs:master Oct 12, 2020
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unquoter accepts incorrect %-sequences containing a space ValueError in unquoter
2 participants