Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Query and QueryVariable type aliases #475

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Hide Query and QueryVariable type aliases #475

merged 1 commit into from
Jul 19, 2020

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jul 19, 2020

Fixes #431

@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #475 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files           2        2           
  Lines         673      673           
  Branches      154      154           
=======================================
  Hits          668      668           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aee9aa...acb9ba5. Read the comment docs.

@asvetlov asvetlov merged commit acc934e into master Jul 19, 2020
@asvetlov asvetlov deleted the hide-type-var branch July 19, 2020 09:51
@uwinx
Copy link

uwinx commented Jul 19, 2020

@asvetlov my $0.01 for the future. What do you think about removing all the code form __init__.py? which may and probably will come as a breaking change.

We can have yarl/_url.py with all the stuff from current __init__.py and have single line with import like from ._url import URL in new __init__.py. IMO, Otherwise yarl has pretty bad public API.

@asvetlov
Copy link
Member Author

Do you mean the number of internal names exposed by __init__.py?

@uwinx
Copy link

uwinx commented Jul 20, 2020

yes.

@asvetlov
Copy link
Member Author

These internal names are not exposed by __all__, so the situation is not dramatically bad.
I'm +0 for the change (need to finish all pending PRs first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Query, QueryType typevars in .pyi
2 participants