-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace self._val
with separate properties
#1397
Conversation
CodSpeed Performance ReportMerging #1397 will improve performances by 57.36%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1397 +/- ##
==========================================
+ Coverage 96.01% 96.05% +0.03%
==========================================
Files 31 31
Lines 5692 5748 +56
Branches 353 342 -11
==========================================
+ Hits 5465 5521 +56
Misses 201 201
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This seems slower and less readable |
Going to try one more thing before I throw in the towel on this one |
Thats a lot more readable.... lets see if its +/- on performance though |
still 8% slower making the URL If we move the URL inside the |
that works but need to make sure we do not cache on default value since unpickling mutates the object and everything else expected |
self._val
with separate properties
#1397 made this a less concise, clean it up a bit
self._val
has been eliminated and replaced withself._scheme, self._netloc, self._path, self._query, self._fragment
Second part of #1396
Closes #172