Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for passing encoded SplitResult to create a URL #1366

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 21, 2024

We are missing direct coverage for this

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 21, 2024
@bdraco bdraco changed the title Add coverage for passing encoded SplitResult to create a URL object Add coverage for passing encoded SplitResult to create a URL Oct 21, 2024
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #1366 will not alter performance

Comparing cov_split_result (93637fe) with master (ed2d648)

Summary

✅ 83 untouched benchmarks

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (ed2d648) to head (93637fe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1366   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files          31       31           
  Lines        5635     5638    +3     
  Branches      348      348           
=======================================
+ Hits         5408     5411    +3     
  Misses        201      201           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.97% <100.00%> (+<0.01%) ⬆️
MyPy 45.52% <0.00%> (-0.03%) ⬇️
OS-Linux 99.50% <100.00%> (+0.02%) ⬆️
OS-Windows 99.56% <100.00%> (+0.02%) ⬆️
OS-macOS 99.24% <100.00%> (+0.02%) ⬆️
Py-3.10.11 99.22% <100.00%> (+0.02%) ⬆️
Py-3.10.15 99.45% <100.00%> (+0.02%) ⬆️
Py-3.11.10 99.45% <100.00%> (+0.02%) ⬆️
Py-3.11.9 99.22% <100.00%> (+0.02%) ⬆️
Py-3.12.7 99.45% <100.00%> (+0.02%) ⬆️
Py-3.13.0 99.45% <100.00%> (+0.02%) ⬆️
Py-3.9.13 99.17% <100.00%> (+0.02%) ⬆️
Py-3.9.20 99.41% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.16 99.47% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.17 99.49% <100.00%> (+0.02%) ⬆️
VM-macos-latest 99.24% <100.00%> (+0.02%) ⬆️
VM-ubuntu-latest 99.50% <100.00%> (+0.02%) ⬆️
VM-windows-latest 99.56% <100.00%> (+0.02%) ⬆️
pytest 99.50% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit bbb8257 into master Oct 21, 2024
44 of 46 checks passed
@bdraco bdraco deleted the cov_split_result branch October 21, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant