Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop variable being redefined in cache_configure #1363

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 21, 2024

The loop variable size should not get redefined. Python for doesn't define its own scope. Add more coverage to make sure everything works as expected with the backwards compat.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 21, 2024
@bdraco bdraco changed the title Fix loop variable being redefined in cache_configure Fix loop variable being redefined in cache_configure Oct 21, 2024
@bdraco bdraco marked this pull request as ready for review October 21, 2024 06:35
@bdraco bdraco enabled auto-merge (squash) October 21, 2024 06:39
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #1363 will not alter performance

Comparing cache_configure_back_compat_cleanup (e9fb88f) with master (f42f34e)

Summary

✅ 83 untouched benchmarks

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (12413d3) to head (e9fb88f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
+ Coverage   95.95%   95.97%   +0.01%     
==========================================
  Files          30       31       +1     
  Lines        5610     5635      +25     
  Branches      346      348       +2     
==========================================
+ Hits         5383     5408      +25     
  Misses        201      201              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.97% <100.00%> (+0.01%) ⬆️
MyPy 45.55% <100.00%> (+0.25%) ⬆️
OS-Linux 99.48% <100.00%> (+0.02%) ⬆️
OS-Windows 99.54% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.22% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.19% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.43% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.43% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.19% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.43% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.43% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 99.15% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.39% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.44% <100.00%> (?)
Py-pypy7.3.17 99.47% <100.00%> (?)
VM-macos-latest 99.22% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.48% <100.00%> (+0.02%) ⬆️
VM-windows-latest 99.54% <100.00%> (+<0.01%) ⬆️
pytest 99.48% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit ed2d648 into master Oct 21, 2024
44 of 46 checks passed
@bdraco bdraco deleted the cache_configure_back_compat_cleanup branch October 21, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant