Fix setting the idna_encode_size #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a refactoring error in #1348 that set this to the decode size Fix the bug and add coverage to ensure it does not break again. This change never made it to a release
psf-chronographer
bot
added
the
bot:chronographer:provided
CodSpeed Performance ReportMerging #1357 will improve performances by 8.03%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
=======================================
Coverage 96.14% 96.15%
=======================================
Files 28 28
Lines 5554 5560 +6
Branches 351 346 -5
=======================================
+ Hits 5340 5346 +6
Misses 188 188
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a refactoring error in #1348 that set encode size to the decode size
Fix the bug and add coverage to ensure it does not break again.
This change never made it to a release before the problem was discovered