-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract _make_netloc
from URL object
#1351
Conversation
The @classmethod here is a bit slower
_make_netloc
from URL object
CodSpeed Performance ReportMerging #1351 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
=======================================
Coverage 96.13% 96.13%
=======================================
Files 27 27
Lines 5539 5539
Branches 358 357 -1
=======================================
Hits 5325 5325
Misses 188 188
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The
@classmethod
here is a bit slower, and it was only a@classmethod
to accessself._QUOTER
which is a constant anyways