Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract _make_netloc from URL object #1351

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Extract _make_netloc from URL object #1351

merged 6 commits into from
Oct 21, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 21, 2024

The @classmethod here is a bit slower, and it was only a @classmethod to access self._QUOTER which is a constant anyways

@bdraco bdraco changed the title Extract _make_netloc from URL object Extract _make_netloc from URL object Oct 21, 2024
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #1351 will not alter performance

Comparing extract__make_netloc (06118b6) with master (8f98545)

Summary

✅ 83 untouched benchmarks

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (8f98545) to head (06118b6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          27       27           
  Lines        5539     5539           
  Branches      358      357    -1     
=======================================
  Hits         5325     5325           
  Misses        188      188           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 96.13% <100.00%> (ø)
MyPy 45.22% <100.00%> (+0.01%) ⬆️
OS-Linux 99.23% <96.96%> (ø)
OS-Windows 99.27% <96.96%> (ø)
OS-macOS 98.96% <96.96%> (ø)
Py-3.10.11 98.94% <96.96%> (ø)
Py-3.10.15 99.18% <96.96%> (ø)
Py-3.11.10 99.18% <96.96%> (ø)
Py-3.11.9 98.94% <96.96%> (ø)
Py-3.12.7 99.18% <96.96%> (ø)
Py-3.13.0 99.18% <96.96%> (ø)
Py-3.9.13 98.90% <96.96%> (ø)
Py-3.9.20 99.14% <96.96%> (ø)
Py-pypy7.3.16 99.18% <96.96%> (ø)
Py-pypy7.3.17 99.20% <96.96%> (ø)
VM-macos-latest 98.96% <96.96%> (ø)
VM-ubuntu-latest 99.23% <96.96%> (ø)
VM-windows-latest 99.27% <96.96%> (ø)
pytest 99.23% <96.96%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yarl/_url.py Outdated Show resolved Hide resolved
yarl/_url.py Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review October 21, 2024 03:42
@bdraco bdraco merged commit 04f382f into master Oct 21, 2024
42 of 46 checks passed
@bdraco bdraco deleted the extract__make_netloc branch October 21, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant