Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of URL.with_scheme #1322

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Improve performance of URL.with_scheme #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9adc5bc
Improve performance of URL.with_scheme
bdraco Oct 18, 2024
de3c10e
changelog
bdraco Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/1322.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improved performance of the :py:meth:`~yarl.URL.with_scheme` method -- by :user:`bdraco`.
6 changes: 4 additions & 2 deletions yarl/_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,13 +1172,15 @@ def with_scheme(self, scheme: str) -> "URL":
if not isinstance(scheme, str):
raise TypeError("Invalid scheme type")
lower_scheme = scheme.lower()
if not self._val.netloc and lower_scheme in SCHEME_REQUIRES_HOST:
_, netloc, path, query, fragment = self._val
if not netloc and lower_scheme in SCHEME_REQUIRES_HOST:
msg = (
"scheme replacement is not allowed for "
f"relative URLs for the {lower_scheme} scheme"
)
raise ValueError(msg)
return self._from_val(self._val._replace(scheme=lower_scheme))
val = tuple.__new__(SplitResult, (lower_scheme, netloc, path, query, fragment))
return self._from_val(val)

def with_user(self, user: Union[str, None]) -> "URL":
"""Return a new URL with user replaced.
Expand Down
Loading