-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of URL.parent
#1321
Conversation
CodSpeed Performance ReportMerging #1321 will improve performances by 73.58%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1321 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 27 27
Lines 5427 5428 +1
Branches 329 329
=======================================
+ Hits 5209 5210 +1
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
URL.parent
We have some missing tests for this. Need to add them first |
Avoid calling
SplitResult._replace
since its much slower, and instead replace with fastNamedTuple
creationtuple.__new__(Type, (...)