Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of URL.parent #1321

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Improve performance of URL.parent #1321

merged 3 commits into from
Oct 18, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 18, 2024

Avoid calling SplitResult._replace since its much slower, and instead replace with fast NamedTuple creation tuple.__new__(Type, (...)

Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #1321 will improve performances by 73.58%

Comparing parent (f1bf93a) with master (6bc3bc2)

Summary

⚡ 1 improvements
✅ 78 untouched benchmarks

Benchmarks breakdown

Benchmark master parent Change
test_url_with_path_parent 999.5 µs 575.8 µs +73.58%

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (443ba5c) to head (f1bf93a).
Report is 125 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1321   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          27       27           
  Lines        5427     5428    +1     
  Branches      329      329           
=======================================
+ Hits         5209     5210    +1     
  Misses        192      192           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.98% <100.00%> (+<0.01%) ⬆️
MyPy 44.47% <100.00%> (+0.01%) ⬆️
OS-Linux 99.32% <100.00%> (+0.02%) ⬆️
OS-Windows 99.37% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.05% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.03% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.03% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.98% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.23% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.28% <100.00%> (?)
Py-pypy7.3.17 99.30% <100.00%> (?)
VM-macos-latest 99.05% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.32% <100.00%> (+0.02%) ⬆️
VM-windows-latest 99.37% <100.00%> (+<0.01%) ⬆️
pytest 99.32% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 18, 2024
@bdraco bdraco marked this pull request as ready for review October 18, 2024 01:20
@bdraco bdraco changed the title Improve performance of URL.parent Improve performance of URL.parent Oct 18, 2024
@bdraco bdraco marked this pull request as draft October 18, 2024 01:22
@bdraco
Copy link
Member Author

bdraco commented Oct 18, 2024

We have some missing tests for this. Need to add them first

@bdraco bdraco marked this pull request as ready for review October 18, 2024 02:14
@bdraco bdraco enabled auto-merge (squash) October 18, 2024 02:14
@bdraco bdraco merged commit 8e445f4 into master Oct 18, 2024
41 of 44 checks passed
@bdraco bdraco deleted the parent branch October 18, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant