Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of the URL.update_query method #1309

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 17, 2024

Improve performance of the URL.update_query method

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 17, 2024
Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #1309 will improve performances by 63.29%

Comparing update_query_pref (47f68c6) with master (ac2e975)

Summary

⚡ 2 improvements
✅ 73 untouched benchmarks

Benchmarks breakdown

Benchmark master update_query_pref Change
test_update_query_empty 521.6 µs 422.6 µs +23.43%
test_update_query_none 246.1 µs 150.7 µs +63.29%

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (ac2e975) to head (47f68c6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1309   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files          27       27           
  Lines        5372     5373    +1     
  Branches      326      326           
=======================================
+ Hits         5154     5155    +1     
  Misses        192      192           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.94% <100.00%> (+<0.01%) ⬆️
MyPy 44.48% <87.50%> (+0.01%) ⬆️
OS-Linux 99.31% <100.00%> (ø)
OS-Windows 99.36% <100.00%> (ø)
OS-macOS 99.04% <100.00%> (ø)
Py-3.10.11 99.01% <100.00%> (ø)
Py-3.10.15 99.27% <100.00%> (ø)
Py-3.11.10 99.27% <100.00%> (ø)
Py-3.11.9 99.01% <100.00%> (ø)
Py-3.12.7 99.27% <100.00%> (ø)
Py-3.13.0 99.27% <100.00%> (ø)
Py-3.9.13 98.97% <100.00%> (ø)
Py-3.9.20 99.22% <100.00%> (ø)
Py-pypy7.3.16 99.27% <100.00%> (ø)
Py-pypy7.3.17 99.29% <100.00%> (ø)
VM-macos-latest 99.04% <100.00%> (ø)
VM-ubuntu-latest 99.31% <100.00%> (ø)
VM-windows-latest 99.36% <100.00%> (ø)
pytest 99.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco force-pushed the update_query_pref branch 2 times, most recently from 440346a to 61c0dc0 Compare October 17, 2024 21:44
@bdraco bdraco closed this Oct 17, 2024
@bdraco bdraco reopened this Oct 17, 2024
@bdraco
Copy link
Member Author

bdraco commented Oct 17, 2024

Well nothing improved because we are missing benchmarks for update_query

@bdraco bdraco force-pushed the update_query_pref branch from 61c0dc0 to 47f68c6 Compare October 17, 2024 22:56
@bdraco bdraco marked this pull request as ready for review October 17, 2024 23:14
@bdraco bdraco merged commit 96649e7 into master Oct 17, 2024
43 of 46 checks passed
@bdraco bdraco deleted the update_query_pref branch October 17, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant