-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of the URL.origin
method
#1306
Conversation
f4d24b2
to
606d48a
Compare
URL.origin
method
CodSpeed Performance ReportMerging #1306 will not alter performanceComparing Summary
|
Looks like origin benchmark isn't good because its testing the cache |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1306 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 27 27
Lines 5348 5351 +3
Branches 322 323 +1
=======================================
+ Hits 5130 5133 +3
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3985482
to
9df97bc
Compare
The benchmark could still be better because codspeed is re-running it again to avoid jitter which still hits the cache. The actual improvement is better than the 4% its showing. Will need to think about how to improve the benchmark some more, but no reason to wait for a solution as this is clearly faster for all the other cases as well |
Improve performance of origin