-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of URL.build
by avoiding operations
#1297
Conversation
CodSpeed Performance ReportMerging #1297 will improve performances by 31.98%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1297 +/- ##
=======================================
Coverage 95.87% 95.88%
=======================================
Files 27 27
Lines 5290 5297 +7
Branches 316 316
=======================================
+ Hits 5072 5079 +7
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1000b77
to
db26fd3
Compare
URL.build
by avoiding operations
URL.build
had a few places left where performance could be improvedURL
object twice when passingquery
as we already had a method to convertquery
to string, and we shouldn't make two objects to build a URL