Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small speed up to human_repr #1274

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Small speed up to human_repr #1274

merged 1 commit into from
Oct 15, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 15, 2024

We can avoid re-encoding the host here as well as we already have the value and all that was missing was the the IPv6 brackets

Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #1274 will improve performances by 10.53%

Comparing human_repr (a1f00a8) with master (21b38a2)

Summary

⚡ 2 improvements
✅ 46 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark master human_repr Change
test_human_repr 11.9 ms 10.8 ms +10.53%
test_url_make_with_many_hosts 6.3 ms 5.7 ms +8.9%
🆕 test_url_origin_with_user_pass N/A 86.6 µs N/A

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (84677e9) to head (a1f00a8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
- Coverage   95.74%   95.74%   -0.01%     
==========================================
  Files          27       27              
  Lines        5216     5214       -2     
  Branches      305      305              
==========================================
- Hits         4994     4992       -2     
  Misses        195      195              
  Partials       27       27              
Flag Coverage Δ
CI-GHA 95.74% <100.00%> (-0.01%) ⬇️
MyPy 44.13% <100.00%> (-0.03%) ⬇️
OS-Linux 99.29% <100.00%> (-0.01%) ⬇️
OS-Windows 99.34% <100.00%> (-0.01%) ⬇️
OS-macOS 99.00% <100.00%> (-0.01%) ⬇️
Py-3.10.11 98.98% <100.00%> (-0.01%) ⬇️
Py-3.10.15 99.24% <100.00%> (-0.01%) ⬇️
Py-3.11.10 99.24% <100.00%> (-0.01%) ⬇️
Py-3.11.9 98.98% <100.00%> (-0.01%) ⬇️
Py-3.12.7 99.24% <100.00%> (-0.01%) ⬇️
Py-3.13.0 99.24% <100.00%> (-0.01%) ⬇️
Py-3.9.13 98.93% <100.00%> (-0.01%) ⬇️
Py-3.9.20 99.19% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 99.24% <100.00%> (?)
Py-pypy7.3.17 99.27% <100.00%> (-0.01%) ⬇️
VM-macos-latest 99.00% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 99.29% <100.00%> (-0.01%) ⬇️
VM-windows-latest 99.34% <100.00%> (-0.01%) ⬇️
pytest 99.29% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 15, 2024
@bdraco bdraco marked this pull request as ready for review October 15, 2024 11:36
@bdraco bdraco merged commit 32a35be into master Oct 15, 2024
43 of 46 checks passed
@bdraco bdraco deleted the human_repr branch October 15, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant