Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify processing of username and password for unencoded URLs #1268

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 15, 2024

There was no need to check for None for the quoting

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (affe81c) to head (8da4b67).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1268   +/-   ##
=======================================
  Coverage   95.72%   95.72%           
=======================================
  Files          27       27           
  Lines        5188     5188           
  Branches      299      299           
=======================================
  Hits         4966     4966           
  Misses        195      195           
  Partials       27       27           
Flag Coverage Δ
CI-GHA 95.72% <100.00%> (ø)
MyPy 43.92% <100.00%> (ø)
OS-Linux 99.28% <100.00%> (ø)
OS-Windows 99.34% <100.00%> (ø)
OS-macOS 99.00% <100.00%> (ø)
Py-3.10.11 98.97% <100.00%> (ø)
Py-3.10.15 99.23% <100.00%> (ø)
Py-3.11.10 99.23% <100.00%> (ø)
Py-3.11.9 98.97% <100.00%> (ø)
Py-3.12.7 99.23% <100.00%> (ø)
Py-3.13.0 99.23% <100.00%> (ø)
Py-3.9.13 98.92% <100.00%> (ø)
Py-3.9.20 99.19% <100.00%> (ø)
Py-pypy7.3.16 99.24% <100.00%> (ø)
Py-pypy7.3.17 99.26% <100.00%> (ø)
VM-macos-latest 99.00% <100.00%> (ø)
VM-ubuntu-latest 99.28% <100.00%> (ø)
VM-windows-latest 99.34% <100.00%> (ø)
pytest 99.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #1268 will not alter performance

Comparing user_pass_logic (8da4b67) with master (affe81c)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review October 15, 2024 05:22
@bdraco bdraco merged commit ca9f47a into master Oct 15, 2024
43 of 46 checks passed
@bdraco bdraco deleted the user_pass_logic branch October 15, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant