-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL.build
not validating that path
has a leading slash when passing authority
#1265
Conversation
CodSpeed Performance ReportMerging #1265 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1265 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 27 27
Lines 5214 5219 +5
Branches 305 306 +1
=======================================
+ Hits 4992 4997 +5
Misses 195 195
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b09f804
to
be0b185
Compare
authority
authority
URL.build
not validating that path has a leading slash when passing authority
URL.build
not validating that path has a leading slash when passing authority
URL.build
not validating that path
has a leading slash when passing authority
27a5395
to
91873e4
Compare
Could use another set of 👀 to make sure |
2b72921
to
d940ce4
Compare
slept on this one and much more confident the change is correct. |
…ng authority The validation only worked when host was passed
d940ce4
to
7983876
Compare
What do these changes do?
Fix
URL.build
not validating that path has a leading slash when passingauthority
The validation only worked when
host
was passedAre there changes in behavior for the user?
Validation of leading
/
in path now works forauthority
instead of justhost
as intended