Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL.build not validating that path has a leading slash when passing authority #1265

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 15, 2024

What do these changes do?

Fix URL.build not validating that path has a leading slash when passing authority
The validation only worked when host was passed

Are there changes in behavior for the user?

Validation of leading / in path now works for authority instead of just host as intended

Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #1265 will not alter performance

Comparing test_build_with_authority_fix (7983876) with master (5b3592a)

Summary

✅ 49 untouched benchmarks

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (5b3592a) to head (7983876).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1265   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files          27       27           
  Lines        5214     5219    +5     
  Branches      305      306    +1     
=======================================
+ Hits         4992     4997    +5     
  Misses        195      195           
  Partials       27       27           
Flag Coverage Δ
CI-GHA 95.74% <100.00%> (+<0.01%) ⬆️
MyPy 44.11% <58.33%> (-0.03%) ⬇️
OS-Linux 99.24% <83.33%> (-0.05%) ⬇️
OS-Windows 99.30% <83.33%> (-0.05%) ⬇️
OS-macOS 98.96% <83.33%> (-0.05%) ⬇️
Py-3.10.11 98.93% <83.33%> (-0.05%) ⬇️
Py-3.10.15 99.19% <83.33%> (-0.05%) ⬇️
Py-3.11.10 99.19% <83.33%> (-0.05%) ⬇️
Py-3.11.9 98.93% <83.33%> (-0.05%) ⬇️
Py-3.12.7 99.19% <83.33%> (-0.05%) ⬇️
Py-3.13.0 99.19% <83.33%> (-0.05%) ⬇️
Py-3.9.13 98.89% <83.33%> (-0.05%) ⬇️
Py-3.9.20 99.15% <83.33%> (-0.05%) ⬇️
Py-pypy7.3.16 99.20% <83.33%> (-0.05%) ⬇️
Py-pypy7.3.17 99.22% <83.33%> (-0.05%) ⬇️
VM-macos-latest 98.96% <83.33%> (-0.05%) ⬇️
VM-ubuntu-latest 99.24% <83.33%> (-0.05%) ⬇️
VM-windows-latest 99.30% <83.33%> (-0.05%) ⬇️
pytest 99.24% <83.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco force-pushed the test_build_with_authority_fix branch from b09f804 to be0b185 Compare October 15, 2024 04:22
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 15, 2024
CHANGES/1265.bugfix.rst Outdated Show resolved Hide resolved
@bdraco bdraco changed the title Fix URL.build not validating that path has a leading slash when passing authority Fix URL.build not validating that path has a leading slash when passing authority Oct 15, 2024
@bdraco bdraco changed the title Fix URL.build not validating that path has a leading slash when passing authority Fix URL.build not validating that path has a leading slash when passing authority Oct 15, 2024
@bdraco bdraco changed the title Fix URL.build not validating that path has a leading slash when passing authority Fix URL.build not validating that path has a leading slash when passing authority Oct 15, 2024
@bdraco bdraco force-pushed the test_build_with_authority_fix branch from 27a5395 to 91873e4 Compare October 15, 2024 05:11
@bdraco bdraco marked this pull request as ready for review October 15, 2024 05:16
@bdraco
Copy link
Member Author

bdraco commented Oct 15, 2024

Could use another set of 👀 to make sure authority is supposed to have this validation. Would be very surprised if not since authority is in the validation message but maybe I'm missing something....

@bdraco bdraco force-pushed the test_build_with_authority_fix branch 2 times, most recently from 2b72921 to d940ce4 Compare October 15, 2024 06:32
@bdraco bdraco closed this Oct 15, 2024
@bdraco bdraco reopened this Oct 15, 2024
@bdraco
Copy link
Member Author

bdraco commented Oct 15, 2024

slept on this one and much more confident the change is correct.

@bdraco bdraco force-pushed the test_build_with_authority_fix branch from d940ce4 to 7983876 Compare October 15, 2024 12:09
@bdraco bdraco merged commit f48b0d6 into master Oct 15, 2024
41 of 46 checks passed
@bdraco bdraco deleted the test_build_with_authority_fix branch October 15, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant