Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of constructing query strings with int values #1259

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 13, 2024

int was a lot more common than I expected in production.

Performance regressed in #1139 to answer feature request #945 as we didn't have performance measurements in place when that PR was made

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (5d6ff6c) to head (81ad1d8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1259   +/-   ##
=======================================
  Coverage   95.84%   95.85%           
=======================================
  Files          27       27           
  Lines        5180     5182    +2     
  Branches      316      317    +1     
=======================================
+ Hits         4965     4967    +2     
  Misses        189      189           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.83% <100.00%> (+<0.01%) ⬆️
MyPy 43.93% <100.00%> (+0.02%) ⬆️
OS-Linux 99.35% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.41% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.07% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.97% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.97% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 98.92% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 99.19% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.92% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.19% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 99.24% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.24% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.26% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.07% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.35% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.41% <100.00%> (+<0.01%) ⬆️
pytest 99.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #1259 will improve performances by ×2.8

Comparing improve_query_int_perf (81ad1d8) with master (5d6ff6c)

Summary

⚡ 1 improvements
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmark master improve_query_int_perf Change
test_url_make_with_int_query_mapping 3.4 ms 1.2 ms ×2.8

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 13, 2024
@bdraco bdraco marked this pull request as ready for review October 13, 2024 17:25
@bdraco bdraco merged commit 4782275 into master Oct 13, 2024
49 of 51 checks passed
@bdraco bdraco deleted the improve_query_int_perf branch October 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant