-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of converting URL to string #1234
Conversation
CodSpeed Performance ReportMerging #1234 will improve performances by ×3.1Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1234 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 27 27
Lines 5097 5106 +9
Branches 302 306 +4
=======================================
+ Hits 4882 4891 +9
Misses 189 189
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5b1ff3f
to
1ec700d
Compare
Not sure if this is worth it or not, but the string convert method are a bit higher than everything elseSeems like 71%-3x speed up is worth it
Calling urllib's urlunsplit was quite a bit more expensive than expected as seen in the benchmarks.