Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with_scheme checks when passed scheme is not lowercase #1189

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 11, 2024

What do these changes do?

Fix with_scheme checks when passed scheme is not lowercase

Are there changes in behavior for the user?

bugfix

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 11, 2024
@bdraco bdraco marked this pull request as ready for review October 11, 2024 18:18
@bdraco bdraco enabled auto-merge (squash) October 11, 2024 18:25
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (fe96599) to head (a1493ad).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   95.58%   95.59%           
=======================================
  Files          25       25           
  Lines        4871     4881   +10     
  Branches      259      259           
=======================================
+ Hits         4656     4666   +10     
  Misses        189      189           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.57% <100.00%> (+<0.01%) ⬆️
MyPy 42.48% <100.00%> (+0.25%) ⬆️
OS-Linux 99.40% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.47% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.10% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.99% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.28% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.28% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.99% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.28% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.28% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 98.94% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 99.22% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.94% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.22% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 99.28% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.28% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.31% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.10% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.40% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.47% <100.00%> (+<0.01%) ⬆️
pytest 99.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit e342bcc into master Oct 11, 2024
47 of 49 checks passed
@bdraco bdraco deleted the upper_scheme branch October 11, 2024 18:30
bdraco added a commit that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant