-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of _encode_host #1176
Conversation
While this is wrong, we probably shouldn't change it for IPv4.... since we aren't supposed to support it for IPv6 according to https://url.spec.whatwg.org/
There likely isn't a use case for a zone in an IPv4 address but there is for IPv6 (maybe not in practice though). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
- Coverage 95.57% 95.57% -0.01%
==========================================
Files 30 30
Lines 4926 4924 -2
Branches 448 447 -1
==========================================
- Hits 4708 4706 -2
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What do these changes do?
Improve performance of _encode_host
This one is very small, I only noticed it because I was looking over
_encode_host
and wondering why we were looking for an IP zone outside of the ip address block
Are there changes in behavior for the user?
no
before
after