-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host_subcomponent
property
#1159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The brackets were missing when the URL was convert to a string fixes #1157
for more information, see https://pre-commit.ci
bdraco
commented
Sep 26, 2024
psf-chronographer
bot
added
the
bot:chronographer:provided
There is a change note present in this PR
label
Sep 26, 2024
bdraco
commented
Sep 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
+ Coverage 95.45% 95.46% +0.01%
==========================================
Files 30 30
Lines 4792 4807 +15
Branches 425 428 +3
==========================================
+ Hits 4574 4589 +15
Misses 192 192
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns the https://datatracker.ietf.org/doc/html/rfc3986#section-3.2.2 host subcomponent. The only current practical difference between
raw_host
andhost_subcomponent
is that IPv6 addresses are returned bracketed.We can also use this in
aiohttp
at https://github.com/aio-libs/aiohttp/blob/d7cd0613472fd4d9940e37f1c55921f6a1515324/aiohttp/client_reqrep.py#L359 and https://github.com/aio-libs/aiohttp/blob/d7cd0613472fd4d9940e37f1c55921f6a1515324/aiohttp/client_reqrep.py#L609Split from #1158 for #1157
Note that we CANNOT use
self._val.hostname
here because it returns the non-bracketed host