Small optimization to encoding hosts #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid a parition call for most cases since its rare
that the host will have a IPv6 zone
before total time = 0.040
100000 0.040 0.000 0.068 0.000 _url.py:907(_encode_host)
after total time = 0.031
100000 0.031 0.000 0.051 0.000 _url.py:907(_encode_host)
```
print(timeit.timeit('URL("http://user:[email protected]?a+b=c+d").raw_host', globals=globals(), number=100000))
```
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
commented
Sep 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1125 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 30 30
Lines 4635 4638 +3
Branches 409 410 +1
=======================================
+ Hits 4409 4412 +3
Misses 200 200
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Avoid a partition call for most cases since its rare that the host will have a IPv6 zone. We guard all the other partitions but this one was missed, and its one of the most common in the hot path.
before total time = 0.040
100000 0.040 0.000 0.068 0.000 _url.py:907(_encode_host)
after total time = 0.031
100000 0.031 0.000 0.051 0.000 _url.py:907(_encode_host)
Are there changes in behavior for the user?
no