Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify computing ports #1123

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Simplify computing ports #1123

merged 3 commits into from
Sep 7, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 7, 2024

What do these changes do?

Simplify computing ports

Are there changes in behavior for the user?

no

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (67c2c02) to head (d48306e).
Report is 291 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
- Coverage   95.12%   95.12%   -0.01%     
==========================================
  Files          30       30              
  Lines        4640     4636       -4     
  Branches      411      409       -2     
==========================================
- Hits         4414     4410       -4     
  Misses        200      200              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.08% <100.00%> (-0.01%) ⬇️
MyPy 41.06% <100.00%> (-0.06%) ⬇️
OS-Linux 99.38% <100.00%> (-0.01%) ⬇️
OS-Windows 99.47% <100.00%> (-0.01%) ⬇️
OS-macOS 99.08% <100.00%> (-0.01%) ⬇️
Py-3.10.11 98.97% <100.00%> (-0.01%) ⬇️
Py-3.10.14 99.21% <100.00%> (-0.01%) ⬇️
Py-3.11.9 99.21% <100.00%> (-0.01%) ⬇️
Py-3.12.5 99.21% <100.00%> (-0.01%) ⬇️
Py-3.13.0-rc.1 99.21% <100.00%> (-0.01%) ⬇️
Py-3.8.10 98.92% <100.00%> (-0.01%) ⬇️
Py-3.8.18 99.16% <100.00%> (-0.01%) ⬇️
Py-3.9.13 98.92% <100.00%> (-0.01%) ⬇️
Py-3.9.19 99.16% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.11 99.21% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 99.21% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.17 99.24% <100.00%> (-0.01%) ⬇️
VM-macos-latest 99.08% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 99.38% <100.00%> (-0.01%) ⬇️
VM-windows-latest 99.47% <100.00%> (-0.01%) ⬇️
pytest 99.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 7, 2024
@bdraco bdraco marked this pull request as ready for review September 7, 2024 19:56
@bdraco bdraco merged commit 0afe7c5 into master Sep 7, 2024
47 of 49 checks passed
@bdraco bdraco deleted the simp_port branch September 7, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant