Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError with MultiDictProxy and Python 3.8 #1107

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 5, 2024

What do these changes do?

Fix non-subscriptable MultiDictProxy error as seen in #1105 when using older versions of multidict

Screenshot 2024-09-04 at 4 00 13 PM

Are there changes in behavior for the user?

no

Related issue number

fixes #1105

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 5, 2024
@bdraco bdraco changed the title Fix non-subscriptable MultiDictProxy with old multidict Fix TypeError with MultiDictProxy` and Python 3.8 Sep 5, 2024
@bdraco bdraco changed the title Fix TypeError with MultiDictProxy` and Python 3.8 Fix TypeError with MultiDictProxy and Python 3.8 Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (bfef130) to head (542f7ca).
Report is 307 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          30       30           
  Lines        4448     4448           
  Branches      391      391           
=======================================
  Hits         4226     4226           
  Misses        196      196           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 94.96% <100.00%> (ø)
MyPy 39.95% <100.00%> (ø)
OS-Linux 99.35% <100.00%> (ø)
OS-Windows 99.45% <100.00%> (ø)
OS-macOS 99.04% <100.00%> (ø)
Py-3.10.11 98.92% <100.00%> (ø)
Py-3.10.14 99.18% <100.00%> (ø)
Py-3.11.9 99.18% <100.00%> (ø)
Py-3.12.5 99.18% <100.00%> (ø)
Py-3.13.0-rc.1 99.18% <100.00%> (ø)
Py-3.8.10 98.87% <100.00%> (ø)
Py-3.8.18 99.12% <100.00%> (ø)
Py-3.9.13 98.87% <100.00%> (ø)
Py-3.9.19 99.12% <100.00%> (ø)
Py-pypy7.3.11 99.18% <100.00%> (ø)
Py-pypy7.3.16 99.17% <100.00%> (ø)
Py-pypy7.3.17 99.21% <100.00%> (ø)
VM-macos-latest 99.04% <100.00%> (ø)
VM-ubuntu-latest 99.35% <100.00%> (ø)
VM-windows-latest 99.45% <100.00%> (ø)
pytest 99.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Sep 5, 2024

Tested locally, confirmed fixed

@bdraco bdraco marked this pull request as ready for review September 5, 2024 02:05
@bdraco bdraco merged commit 7acfed4 into master Sep 5, 2024
47 of 49 checks passed
@bdraco bdraco deleted the fix_old_multidict branch September 5, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello, I think this change broke python 3.8 support:
1 participant