Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing type on URL.port #1097

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Fix missing type on URL.port #1097

merged 3 commits into from
Sep 4, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 4, 2024

What do these changes do?

Fix missing type on URL.port

Are there changes in behavior for the user?

Fixes mypy error

Related issue number

fixes #1096

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 4, 2024
CHANGES/1097.bugfix.rst Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review September 4, 2024 18:50
@bdraco bdraco enabled auto-merge (squash) September 4, 2024 18:50
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (fd25c6f) to head (487c1ab).
Report is 314 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   94.81%   94.90%   +0.09%     
==========================================
  Files          30       30              
  Lines        4358     4358              
  Branches      382      382              
==========================================
+ Hits         4132     4136       +4     
+ Misses        200      196       -4     
  Partials       26       26              
Flag Coverage Δ
CI-GHA 94.86% <100.00%> (+0.09%) ⬆️
MyPy 39.11% <100.00%> (+0.19%) ⬆️
OS-Linux 99.34% <100.00%> (+0.05%) ⬆️
OS-Windows 99.44% <100.00%> (ø)
OS-macOS 99.02% <100.00%> (?)
Py-3.10.11 98.90% <100.00%> (-0.41%) ⬇️
Py-3.10.14 99.16% <100.00%> (ø)
Py-3.11.9 99.16% <100.00%> (ø)
Py-3.12.5 99.16% <100.00%> (ø)
Py-3.13.0-rc.1 99.16% <100.00%> (ø)
Py-3.8.10 98.85% <100.00%> (-0.41%) ⬇️
Py-3.8.18 99.11% <100.00%> (+0.03%) ⬆️
Py-3.9.13 98.85% <100.00%> (?)
Py-3.9.19 99.11% <100.00%> (+0.25%) ⬆️
Py-pypy7.3.11 99.16% <100.00%> (?)
Py-pypy7.3.16 99.16% <100.00%> (?)
Py-pypy7.3.17 99.19% <100.00%> (?)
VM-macos-latest 99.02% <100.00%> (?)
VM-ubuntu-latest 99.34% <100.00%> (+0.05%) ⬆️
VM-windows-latest 99.44% <100.00%> (ø)
pytest 99.34% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 267afb1 into master Sep 4, 2024
45 of 47 checks passed
@bdraco bdraco deleted the missing_type branch September 4, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing on the port property was missed
1 participant