Replace all Optional with Union

[bdraco]

What do these changes do?

Replace all Optional with Union

We have both in this project: Optional[int] on port and Union[int, None] on explict_port is not so great. This is a short lived change since pyupgrade is going to change them all to type | None once we remove support for older python.

Are there changes in behavior for the user?

no

Related issue number

#1084 (comment)
#1112 (comment)

[bdraco]

Not sure what kind of changelog message this should get.

Also near midnight here so I'll have to pick this up tomorrow.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (f8ba967) to head (5dec476).
Report is 301 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files          30       30           
  Lines        4459     4459           
  Branches      392      392           
=======================================
  Hits         4237     4237           
  Misses        196      196           
  Partials       26       26           

Flag	Coverage Δ
CI-GHA	94.97% <100.00%> (ø)
MyPy	39.89% <95.83%> (ø)
OS-Linux	99.35% <100.00%> (ø)
OS-Windows	99.45% <100.00%> (ø)
OS-macOS	99.04% <100.00%> (ø)
Py-3.10.11	98.93% <100.00%> (ø)
Py-3.10.14	99.18% <100.00%> (ø)
Py-3.11.9	99.18% <100.00%> (ø)
Py-3.12.5	99.18% <100.00%> (ø)
Py-3.13.0-rc.1	99.18% <100.00%> (ø)
Py-3.8.10	98.87% <100.00%> (ø)
Py-3.8.18	99.12% <100.00%> (ø)
Py-3.9.13	98.87% <100.00%> (ø)
Py-3.9.19	99.12% <100.00%> (ø)
Py-pypy7.3.11	99.18% <100.00%> (ø)
Py-pypy7.3.16	99.18% <100.00%> (ø)
Py-pypy7.3.17	99.21% <100.00%> (ø)
VM-macos-latest	99.04% <100.00%> (ø)
VM-ubuntu-latest	99.35% <100.00%> (ø)
VM-windows-latest	99.45% <100.00%> (ø)
pytest	99.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[webknjaz]

Not sure what kind of changelog message this should get.

I'd say “contrib” since it's improving the readability for contributors w/o any influence on how the type checkers would perceive this.