Make scheme
a cached property as well
#1058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this one comes up a lot while profiling #1039
What do these changes do?
Make
scheme
a cached property as wellAre there changes in behavior for the user?
No
This likely makes very little difference, but we might as well include it since we use
@cached_property
for any immutable property we access more than once. Once we can use the cython version per #1065 this will be a bit faster.