Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC3986 compatible URL.join honoring empty segments #1039

Merged
merged 36 commits into from
Aug 30, 2024

lint

f94589c
Select commit
Loading
Failed to load commit list.
Merged

RFC3986 compatible URL.join honoring empty segments #1039

lint
f94589c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 30, 2024 in 0s

62.60% (target 100.00%)

View this Pull Request on Codecov

62.60% (target 100.00%)

Details

Codecov Report

Attention: Patch coverage is 73.49398% with 22 lines in your changes missing coverage. Please review.

Project coverage is 62.60%. Comparing base (84e1c7d) to head (f94589c).

Files with missing lines Patch % Lines
tests/test_url.py 59.52% 17 Missing ⚠️
yarl/_url.py 87.80% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
+ Coverage   62.37%   62.60%   +0.23%     
==========================================
  Files          38       38              
  Lines        6626     6721      +95     
  Branches      356      368      +12     
==========================================
+ Hits         4133     4208      +75     
- Misses       2466     2486      +20     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.