Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize URL string ports per RFC 3986 section 3.2.3 #1033

Merged
merged 19 commits into from
Jul 17, 2024

URL.port - use URL._get_default_port

92744f5
Select commit
Loading
Failed to load commit list.
Merged

Normalize URL string ports per RFC 3986 section 3.2.3 #1033

URL.port - use URL._get_default_port
92744f5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jul 7, 2024 in 0s

45.45% of diff hit (target 62.06%)

View this Pull Request on Codecov

45.45% of diff hit (target 62.06%)

Annotations

Check warning on line 225 in tests/test_url.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

tests/test_url.py#L222-L225

Added lines #L222 - L225 were not covered by tests

Check warning on line 1341 in tests/test_url.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

tests/test_url.py#L1341

Added line #L1341 was not covered by tests

Check warning on line 195 in tests/test_url_update_netloc.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

tests/test_url_update_netloc.py#L194-L195

Added lines #L194 - L195 were not covered by tests

Check warning on line 199 in tests/test_url_update_netloc.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

tests/test_url_update_netloc.py#L197-L199

Added lines #L197 - L199 were not covered by tests

Check warning on line 204 in tests/test_url_update_netloc.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

tests/test_url_update_netloc.py#L201-L204

Added lines #L201 - L204 were not covered by tests

Check warning on line 209 in tests/test_url_update_netloc.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

tests/test_url_update_netloc.py#L206-L209

Added lines #L206 - L209 were not covered by tests

Check warning on line 219 in tests/test_url_update_netloc.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

tests/test_url_update_netloc.py#L219

Added line #L219 was not covered by tests

Check warning on line 301 in yarl/_url.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

yarl/_url.py#L298-L301

Added lines #L298 - L301 were not covered by tests

Check warning on line 303 in yarl/_url.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

yarl/_url.py#L303

Added line #L303 was not covered by tests