-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update_query(None) doesn't clear the query #723
Labels
Comments
4 tasks
Hi, I'd like to work on this issue since it seems no progress has been made recently. Let me know if this is a problem. |
Fixed by #792 |
Closed
1 task
Ferenc-
added a commit
to instana/python-sensor
that referenced
this issue
May 15, 2023
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <[email protected]>
Ferenc-
added a commit
to instana/python-sensor
that referenced
this issue
May 15, 2023
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <[email protected]>
Ferenc-
added a commit
to instana/python-sensor
that referenced
this issue
May 15, 2023
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <[email protected]>
Ferenc-
added a commit
to instana/python-sensor
that referenced
this issue
May 15, 2023
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
url.update_query(None)
doesn't clear the queryTo Reproduce
In reality it does this:
Expected behavior
The doc says:
Logs/tracebacks
Python Version
multidict Version
yarl Version
OS
ubuntu
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: