Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_query(None) doesn't clear the query #723

Closed
1 task done
altvod opened this issue May 10, 2022 · 2 comments
Closed
1 task done

update_query(None) doesn't clear the query #723

altvod opened this issue May 10, 2022 · 2 comments
Labels

Comments

@altvod
Copy link

altvod commented May 10, 2022

Describe the bug

url.update_query(None) doesn't clear the query

To Reproduce

In reality it does this:

>>> URL('https://mysite.org?what=this').update_query(None)
URL('https://mysite.org/?what=this')

Expected behavior

The doc says:

URL.update_query(query)
URL.update_query(**kwargs)
Returns a new URL with query part updated.
...
Clear query if None is passed.

Logs/tracebacks

-

Python Version

$ python --version

Python 3.10.0

multidict Version

$ python -m pip show multidict

Version: 6.0.2

yarl Version

$ python -m pip show yarl

Version: 1.7.2

OS

ubuntu

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@dereckt
Copy link
Contributor

dereckt commented Dec 4, 2022

Hi, I'd like to work on this issue since it seems no progress has been made recently. Let me know if this is a problem.

@dereckt dereckt mentioned this issue Dec 4, 2022
4 tasks
@asvetlov
Copy link
Member

Fixed by #792

Ferenc- added a commit to instana/python-sensor that referenced this issue May 15, 2023
Apparently the parameter passing in our `aiohttp` tests
were incorrect, and was depending on a `yarl` bug [1] that was fixed [2]
in `1.9.0`, and with this new yarl version, our tests started to fail.
This fix corrects the parameter passing, so we can use the latest `yarl`.

[1] aio-libs/yarl#723
[2] aio-libs/yarl#792

Signed-off-by: Ferenc Géczi <[email protected]>
Ferenc- added a commit to instana/python-sensor that referenced this issue May 15, 2023
Apparently the parameter passing in our `aiohttp` tests
were incorrect, and was depending on a `yarl` bug [1] that was fixed [2]
in `1.9.0`, and with this new yarl version, our tests started to fail.
This fix corrects the parameter passing, so we can use the latest `yarl`.

[1] aio-libs/yarl#723
[2] aio-libs/yarl#792

Signed-off-by: Ferenc Géczi <[email protected]>
Ferenc- added a commit to instana/python-sensor that referenced this issue May 15, 2023
Apparently the parameter passing in our `aiohttp` tests
were incorrect, and was depending on a `yarl` bug [1] that was fixed [2]
in `1.9.0`, and with this new yarl version, our tests started to fail.
This fix corrects the parameter passing, so we can use the latest `yarl`.

[1] aio-libs/yarl#723
[2] aio-libs/yarl#792

Signed-off-by: Ferenc Géczi <[email protected]>
Ferenc- added a commit to instana/python-sensor that referenced this issue May 15, 2023
Apparently the parameter passing in our `aiohttp` tests
were incorrect, and was depending on a `yarl` bug [1] that was fixed [2]
in `1.9.0`, and with this new yarl version, our tests started to fail.
This fix corrects the parameter passing, so we can use the latest `yarl`.

[1] aio-libs/yarl#723
[2] aio-libs/yarl#792

Signed-off-by: Ferenc Géczi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants