Skip to content

Commit

Permalink
Remove non-applicable FIXMEs
Browse files Browse the repository at this point in the history
- There is no way to distinguish between `?a=` and `?a` when rebuilding
  a query string.
- The further encoding of query delimiters (`=` and `&` in query
  _values_ is entirely normal and expected.
  • Loading branch information
mjpieters committed Apr 19, 2023
1 parent 163c073 commit 11450de
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions tests/test_url_query.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
URL("http://example.com"),
MultiDict(),
),
(
URL("http://example.com?a"),
MultiDict([("a", "")]),
),
(
URL("http://example.com?a="),
MultiDict([("a", "")]),
Expand Down Expand Up @@ -69,9 +65,7 @@ def test_query_basic_parsing(original_url, expected_query):
)
def test_query_basic_update_query(original_url, expected_query):
new_url = original_url.update_query({})
# FIXME: `?a` becomes `?a=` right now. Maybe support `None` values?
# assert new_url == original_url
assert new_url is not None
assert new_url == original_url


def test_query_dont_unqoute_twice():
Expand Down Expand Up @@ -162,6 +156,3 @@ def test_query_from_empty_update_query(

if "b" in original_url.query:
assert new_url.query["b"] == original_url.query["b"]

# FIXME: Broken because of asymmetric query encoding
# assert new_url == original_url

0 comments on commit 11450de

Please sign in to comment.