Improve performance of URL equality checks (#1315)

aio-libs · Oct 17, 2024 · 052215c · 052215c
1 parent 96649e7
commit 052215c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGES/1315.misc.rst b/CHANGES/1315.misc.rst
@@ -0,0 +1 @@
+Improved performance of :class:`~yarl.URL` equality checks -- by :user:`bdraco`.
diff --git a/yarl/_url.py b/yarl/_url.py
@@ -478,11 +478,13 @@ def __eq__(self, other: object) -> bool:
 
         val1 = self._val
         if not val1.path and val1.netloc:
-            val1 = val1._replace(path="/")
+            scheme, netloc, _, query, fragment = val1
+            val1 = tuple.__new__(SplitResult, (scheme, netloc, "/", query, fragment))
 
         val2 = other._val
         if not val2.path and val2.netloc:
-            val2 = val2._replace(path="/")
+            scheme, netloc, _, query, fragment = val2
+            val2 = tuple.__new__(SplitResult, (scheme, netloc, "/", query, fragment))
 
         return val1 == val2
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Improved performance of :class:`~yarl.URL` equality checks -- by :user:`bdraco`.