Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase lib cover requirement to 100% #8

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Increase lib cover requirement to 100% #8

merged 1 commit into from
Oct 3, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 3, 2024

All the coverage issues have been worked out

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (6c0f300) to head (0bcb6e5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
+ Coverage   69.07%   86.47%   +17.39%     
===========================================
  Files          12       13        +1     
  Lines         540      584       +44     
  Branches       27       50       +23     
===========================================
+ Hits          373      505      +132     
+ Misses        140       63       -77     
+ Partials       27       16       -11     
Flag Coverage Δ
CI-GHA 86.13% <ø> (+17.05%) ⬆️
MyPy 69.07% <ø> (ø)
OS-Linux 99.11% <ø> (?)
OS-Windows 96.29% <ø> (?)
OS-macOS 96.88% <ø> (?)
Py-3.10.11 96.88% <ø> (?)
Py-3.10.15 98.66% <ø> (?)
Py-3.11.10 98.66% <ø> (?)
Py-3.11.9 96.88% <ø> (?)
Py-3.12.6 98.66% <ø> (?)
Py-3.13.0-rc.3 98.66% <ø> (?)
Py-3.8.10 78.22% <ø> (?)
Py-3.8.18 80.00% <ø> (?)
Py-3.9.13 96.88% <ø> (?)
Py-3.9.20 98.66% <ø> (?)
Py-pypy7.3.11 94.17% <ø> (?)
Py-pypy7.3.16 94.17% <ø> (?)
Py-pypy7.3.17 94.17% <ø> (?)
VM-macos-latest 96.88% <ø> (?)
VM-ubuntu-latest 99.11% <ø> (?)
VM-windows-latest 96.29% <ø> (?)
pytest 99.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 3, 2024 14:32
@bdraco bdraco merged commit 6707150 into master Oct 3, 2024
47 of 48 checks passed
@bdraco bdraco deleted the lib_cov branch October 3, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant