Fix cython tracing var name in pep517 backend #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
the
bot:chronographer:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 85.41% 85.41%
=======================================
Files 13 13
Lines 569 569
Branches 47 47
=======================================
Hits 486 486
Misses 67 67
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
webknjaz
reviewed
Oct 7, 2024
| @@ -73,7 +73,7 @@ | |||
| CYTHON_TRACING_CONFIG_SETTING = 'with-cython-tracing' | |||
| """Config setting name toggle to include line tracing to C-exts.""" | |||
|
|
|||
| CYTHON_TRACING_ENV_VAR = 'PROPCACHECYTHON_TRACING' | |||
| CYTHON_TRACING_ENV_VAR = 'PROPCACHE_CYTHON_TRACING' | |||
There was a problem hiding this comment.
We should eventually make it read this from pyproject.toml, perhaps. So the backend could be copied across projects w/o us needing to adapt it..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not documented anywhere so I didn't include a change note