Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for cache miss #65

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add benchmarks for cache miss #65

merged 1 commit into from
Oct 23, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 23, 2024

I realized we should have benchmarks for cache miss as well

Sadly we have to pop out the key every time so that gets included in the benchmark but thats ok as long as we think about that when looking at the data

Sadly we have to pop out the key every time so that gets included
in the benchmark but thats ok as long as we think about that
when looking at the data
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 23, 2024
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #65 will create unknown performance changes

Comparing cache_miss (63af59c) with master (b7be10f)

Summary

🆕 4 new benchmarks
⁉️ 2 (👁 2) dropped benchmarks

Benchmarks breakdown

Benchmark master cache_miss Change
🆕 test_cached_property_cache_hit N/A 39.4 µs N/A
🆕 test_cached_property_cache_miss N/A 115.8 µs N/A
👁 test_cached_property_caching 39.2 µs N/A N/A
🆕 test_under_cached_property_cache_hit N/A 57.7 µs N/A
🆕 test_under_cached_property_cache_miss N/A 111 µs N/A
👁 test_under_cached_property_caching 57.5 µs N/A N/A

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (b7be10f) to head (63af59c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   88.52%   88.93%   +0.41%     
==========================================
  Files          18       18              
  Lines         697      723      +26     
  Branches       70       73       +3     
==========================================
+ Hits          617      643      +26     
  Misses         62       62              
  Partials       18       18              
Flag Coverage Δ
CI-GHA 88.93% <100.00%> (+0.41%) ⬆️
MyPy 77.43% <70.37%> (-0.06%) ⬇️
OS-Linux 99.42% <100.00%> (+0.04%) ⬆️
OS-Windows 95.16% <100.00%> (+0.44%) ⬆️
OS-macOS 95.66% <100.00%> (+0.35%) ⬆️
Py-3.10.11 95.37% <100.00%> (+0.37%) ⬆️
Py-3.10.15 97.68% <100.00%> (+0.18%) ⬆️
Py-3.11.10 97.68% <100.00%> (+0.18%) ⬆️
Py-3.11.9 95.37% <100.00%> (+0.37%) ⬆️
Py-3.12.7 97.68% <100.00%> (+0.18%) ⬆️
Py-3.13.0 97.68% <100.00%> (+0.18%) ⬆️
Py-3.9.13 95.36% <100.00%> (+0.37%) ⬆️
Py-3.9.20 97.68% <100.00%> (+0.18%) ⬆️
Py-pypy7.3.16 97.08% <100.00%> (+0.26%) ⬆️
Py-pypy7.3.17 97.09% <100.00%> (+0.26%) ⬆️
VM-macos-latest 95.66% <100.00%> (+0.35%) ⬆️
VM-ubuntu-latest 99.42% <100.00%> (+0.04%) ⬆️
VM-windows-latest 95.16% <100.00%> (+0.44%) ⬆️
pytest 99.42% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 7dabe63 into master Oct 23, 2024
45 of 46 checks passed
@bdraco bdraco deleted the cache_miss branch October 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant