-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.8 support #57
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
==========================================
- Coverage 88.24% 88.07% -0.17%
==========================================
Files 17 17
Lines 689 671 -18
Branches 70 67 -3
==========================================
- Hits 608 591 -17
+ Misses 63 62 -1
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit config needs to be updated. Also, should we go top-down and drop 3.8 from aiohttp first? Currently, its changelog only mentions the drop in master
/ v4. Should 3.11 be released first?
Probably a good idea. I was waiting for digest auth / middle ware to land in 3.11 before releasing but no reason we can't release 3.11 tomorrow and land it in 3.12 |
I think we should wait a little longer before releasing 3.11. I see no reason to block this on the aiohttp release though. FYI, if you look at https://pypistats.org/packages/aiohttp Python 3.8 is still the second most popular version most days. So, it'd be nice to keep the 3.10 release going till atleast the end of the year. |
Okay, let's not block, then. |
for more information, see https://pre-commit.ci
What do these changes do?
Drop Python 3.8 support
3.8 has reached EOL as of the 7th of October https://devguide.python.org/versions/
Are there changes in behavior for the user?
Drop Python 3.8 support