Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support #57

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Drop Python 3.8 support #57

merged 6 commits into from
Oct 11, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 10, 2024

What do these changes do?

Drop Python 3.8 support

3.8 has reached EOL as of the 7th of October https://devguide.python.org/versions/

Are there changes in behavior for the user?

Drop Python 3.8 support

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 10, 2024
src/propcache/_helpers_py.py Dismissed Show dismissed Hide dismissed
src/propcache/_helpers_py.py Dismissed Show dismissed Hide dismissed
@bdraco bdraco marked this pull request as ready for review October 10, 2024 20:45
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (d6e71b6) to head (c6a2845).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/propcache/_helpers_py.py 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   88.24%   88.07%   -0.17%     
==========================================
  Files          17       17              
  Lines         689      671      -18     
  Branches       70       67       -3     
==========================================
- Hits          608      591      -17     
+ Misses         63       62       -1     
  Partials       18       18              
Flag Coverage Δ
CI-GHA 88.07% <89.47%> (-0.17%) ⬇️
MyPy 77.54% <66.66%> (-0.30%) ⬇️
OS-Linux 99.32% <100.00%> (+0.94%) ⬆️
OS-Windows 94.23% <85.71%> (+0.57%) ⬆️
OS-macOS 94.93% <86.66%> (+0.75%) ⬆️
Py-3.10.11 94.59% <86.66%> (+1.71%) ⬆️
Py-3.10.15 97.29% <100.00%> (+1.82%) ⬆️
Py-3.11.10 97.29% <100.00%> (+1.82%) ⬆️
Py-3.11.9 94.59% <86.66%> (+1.71%) ⬆️
Py-3.12.7 97.29% <100.00%> (+1.82%) ⬆️
Py-3.13.0 97.29% <100.00%> (+1.82%) ⬆️
Py-3.8.10 ?
Py-3.8.18 ?
Py-3.9.13 94.57% <86.66%> (+1.71%) ⬆️
Py-3.9.20 97.28% <100.00%> (+1.83%) ⬆️
Py-pypy7.3.11 ?
Py-pypy7.3.16 96.52% <100.00%> (+1.39%) ⬆️
Py-pypy7.3.17 96.53% <100.00%> (+1.38%) ⬆️
VM-macos-latest 94.93% <86.66%> (+0.75%) ⬆️
VM-ubuntu-latest 99.32% <100.00%> (+0.94%) ⬆️
VM-windows-latest 94.23% <85.71%> (+0.57%) ⬆️
pytest 99.32% <100.00%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES/57.breaking.rst Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit config needs to be updated. Also, should we go top-down and drop 3.8 from aiohttp first? Currently, its changelog only mentions the drop in master / v4. Should 3.11 be released first?

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@bdraco
Copy link
Member Author

bdraco commented Oct 10, 2024

pre-commit config needs to be updated. Also, should we go top-down and drop 3.8 from aiohttp first? Currently, its changelog only mentions the drop in master / v4. Should 3.11 be released first?

Probably a good idea. I was waiting for digest auth / middle ware to land in 3.11 before releasing but no reason we can't release 3.11 tomorrow and land it in 3.12

@Dreamsorcerer
Copy link
Member

pre-commit config needs to be updated. Also, should we go top-down and drop 3.8 from aiohttp first? Currently, its changelog only mentions the drop in master / v4. Should 3.11 be released first?

Probably a good idea. I was waiting for digest auth / middle ware to land in 3.11 before releasing but no reason we can't release 3.11 tomorrow and land it in 3.12

I think we should wait a little longer before releasing 3.11. I see no reason to block this on the aiohttp release though. FYI, if you look at https://pypistats.org/packages/aiohttp Python 3.8 is still the second most popular version most days. So, it'd be nice to keep the 3.10 release going till atleast the end of the year.

@webknjaz
Copy link
Member

Okay, let's not block, then.

tests/conftest.py Fixed Show fixed Hide fixed
tests/conftest.py Outdated Show resolved Hide resolved
@bdraco bdraco merged commit f5ba26c into master Oct 11, 2024
44 checks passed
@bdraco bdraco deleted the drop_38 branch October 11, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants