-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change type from Any to object for under_cached_property.__get__ #50
Conversation
Seems ok downstream in yarl |
Seems ok in aiohttp |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 88.24% 88.24%
=======================================
Files 17 17
Lines 689 689
Branches 98 98
=======================================
Hits 608 608
Misses 63 63
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For calling code, this change could only remove errors, not introduce them (i.e. if using --warn-any-expr). |
Before After |
Super confusing that
|
https://mypy.readthedocs.io/en/latest/dynamic_typing.html#any-vs-object
I'd say we didn't get any complaints so that seems to be the prescribed way to go. |
Too tired and jet lagged to revalidate so I'll leave this for someone else to ✅ and merge or I'll take a look again when I've had some sleep. |
I think this is good to merge as-is, but I wasn't 100% on all the discussions above so I'll leave it until they are resolved above. |
I think it's okay to merge. This is probably best we can do right now. |
Originally posted by @Dreamsorcerer in #38 (comment)