Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type stub fixes #284

Closed
wants to merge 1 commit into from
Closed

Type stub fixes #284

wants to merge 1 commit into from

Conversation

nilehmann
Copy link

  • Type annotations for getall were wrong. The default value should not be of type _T.
  • Also improve type annotations for getone by defining overloads.

@nilehmann nilehmann requested a review from asvetlov as a code owner September 11, 2018 17:27
@nilehmann
Copy link
Author

PR similar to #283, but the type annotations differ. This PR allows for a more permissive type.

@asvetlov
Copy link
Member

thank you. I'll port your changes into #283

@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files           8        8           
  Lines         710      710           
=======================================
  Hits          707      707           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d6e9e...1cafc45. Read the comment docs.

@asvetlov
Copy link
Member

Done as part of #283

@asvetlov asvetlov closed this Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants